Skip to content
This repository has been archived by the owner on Mar 26, 2023. It is now read-only.

Rewrite unit tests for views #72

Merged
merged 29 commits into from
Feb 4, 2022
Merged

Rewrite unit tests for views #72

merged 29 commits into from
Feb 4, 2022

Conversation

harisonmg
Copy link
Owner

@harisonmg harisonmg commented Nov 17, 2021 •
edited
Loading

The new tests use Django's RequestFactory instead of the test client in order to decouple URL resolution from the view functionality. This will enable the implementation of #75 with minimal regressions as well as resolving #58 and #73

@harisonmg harisonmg added the enhancement New feature or request label Nov 17, 2021
@harisonmg harisonmg self-assigned this Nov 17, 2021
@harisonmg harisonmg temporarily deployed to test November 17, 2021 13:14 Inactive
@coveralls
Copy link

coveralls commented Nov 17, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1794913469

  • 1328 of 1335 (99.48%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.687%
Changes Missing Coverage Covered Lines Changed/Added Lines %
records/tests/test_views.py 210 211 99.53%
people/tests/test_views.py 1058 1064 99.44%
Totals Coverage Status
Change from base Build 1425611867: -0.1%
Covered Lines: 5417
Relevant Lines: 5434
💛 - Coveralls

@harisonmg harisonmg temporarily deployed to test November 17, 2021 14:26 Inactive
@harisonmg harisonmg temporarily deployed to test November 17, 2021 14:26 Inactive
@harisonmg harisonmg temporarily deployed to test November 18, 2021 16:34 Inactive
@harisonmg harisonmg temporarily deployed to test November 18, 2021 17:56 Inactive
@harisonmg harisonmg temporarily deployed to test November 19, 2021 18:23 Inactive
@harisonmg harisonmg temporarily deployed to test November 19, 2021 18:24 Inactive
@harisonmg harisonmg changed the title Unit test views Write more isolated unit tests for views, resolves #73 Nov 20, 2021
@harisonmg harisonmg linked an issue Nov 20, 2021 that may be closed by this pull request
Write more isolated unit tests for views #73
Closed
@harisonmg harisonmg changed the title Write more isolated unit tests for views, resolves #73 Write more isolated unit tests for views Nov 20, 2021
@harisonmg harisonmg changed the title Write more isolated unit tests for views Write unit tests for views Nov 20, 2021
@harisonmg harisonmg changed the title Write unit tests for views Rewrite unit tests for views Nov 20, 2021
@harisonmg harisonmg changed the title Rewrite unit tests for views Rewrite unit tests for views, resolves #58 Nov 20, 2021
@harisonmg harisonmg linked an issue Nov 20, 2021 that may be closed by this pull request
Interpersonal relationship not found in view tests when the child creation form is submitted with is_parent=True #58
Closed
@harisonmg harisonmg changed the title Rewrite unit tests for views, resolves #58 Rewrite unit tests for views Nov 20, 2021
@harisonmg harisonmg temporarily deployed to test December 4, 2021 20:49 Inactive
@harisonmg harisonmg temporarily deployed to test December 4, 2021 20:49 Inactive
@harisonmg harisonmg temporarily deployed to test February 4, 2022 12:01 Inactive
@harisonmg harisonmg temporarily deployed to test February 4, 2022 12:01 Inactive
@harisonmg harisonmg temporarily deployed to test February 4, 2022 12:28 Inactive
@harisonmg harisonmg temporarily deployed to test February 4, 2022 12:28 Inactive
@harisonmg harisonmg merged commit aee11d8 into main Feb 4, 2022
@harisonmg harisonmg deleted the unit-test-views branch February 4, 2022 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@harisonmg harisonmg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@harisonmg @coveralls